Skip to content

CSPL-3775 extract common code in tests#1788

Merged
kasiakoziol merged 62 commits intodevelopfrom
feature/CSPL-3775-extract-common-code-in-tests
Apr 22, 2026
Merged

CSPL-3775 extract common code in tests#1788
kasiakoziol merged 62 commits intodevelopfrom
feature/CSPL-3775-extract-common-code-in-tests

Conversation

@kasiakoziol
Copy link
Copy Markdown
Collaborator

@kasiakoziol kasiakoziol commented Mar 20, 2026 •
edited
Loading

Description

It extracts common code under test/ to remove duplicates and enhance test readability and usability.

Key Changes

  • Consolidate duplicate V3 (master) and V4 (manager) test files into shared _shared.go + _test.go pairs with table-driven version configs
  • Delete ~30 redundant per-variant files (~5000 lines removed)
  • Add reusable version-aware deploy and verify helpers to the shared test utilities
  • Add watch-based verification utilities for faster and more reliable phase checks
  • Extract repeated multi-line verification patterns into shared helper functions
  • Inline single-use helpers and replace inline closures with reusable typed methods
  • Remove redundant guard clauses, double-verification calls, and dead code
  • Simplify variable declarations and replace hardcoded strings with constants
  • Fix naming conventions, add missing godoc, and standardize comments
  • Adopt shared helpers across appframework tests to reduce inline boilerplate

Testing and Verification

Automated tests

Related Issues

Jira: https://splunk.atlassian.net/browse/CSPL-4515

PR Checklist

  • Code changes adhere to the project's coding standards.
  • Relevant unit and integration tests are included.
  • Documentation has been updated accordingly.
  • All tests pass locally.
  • The PR description follows the project's guidelines.

kasiakoziol and others added 29 commits March 16, 2026 07:05
@kasiakoziol
Feature/CSPL-4397 Eliminate reliance on time in tests (#1735)
00f5b5a 
* CSPL-4397 Remove time dependency from tests

* CSPL-4397 Removing test reliance on time

* CSPL-4397 Adjusting timeouts

* CSPL-4354 Fixing time dependencies in unit tests and fixing timeouts in integ tests

* CSPL-4397 Move to using watch

* CSPL-4397 Refactor pod reset detection to use UID-based tracking instead of time-based comparison, add fail-fast test prerequisites validation, and improve code clarity with variable renaming

* CSPL-4397 Refactoring

* CSPL-4397 Addressing comments
@kasiakoziol
Merge branch 'develop' into feature/test-refactoring
03bf955
@kasiakoziol
CSPL-4602 Moving duplicated code for LM tests to a shared codebase (#…
820d9c7 
…1768)

* CSPL-4602 Moving duplicated code for LM tests to a shared codebase

* CSPL-4602 Addinf license manager tests to workflows

* CSPL-4602 Address comments

* CSPL-4602 Moving LM shared test utils to licensemanager package

* CSPL-4602 Addressing base branch changes
@kasiakoziol
Feature/cspl 4377 remove panic from test (#1777)
064e240 
* CSPL-4377 Get rid of not expected panic in tests

* CSPL-4377 Check error for app disablement in tests
@kasiakoziol
CSPL-3775 Extract setup/teardown functions
5fe13d8
@kasiakoziol
Merge branch 'feature/test-refactoring' into feature/CSPL-3775-extrac…
69aa50c 
…t-common-code-in-tests
@kasiakoziol
CSPL-3775 Extract common code for secret tests
3fd048a
@kasiakoziol
CSPL-3775 Extract CRUD common code
49d74bc
@kasiakoziol
CSPL-3775 Extract common code for smartstore tests
c833d43
@kasiakoziol
CSPL-3775 Combining code into re-usable functions
7f2a3fb
@kasiakoziol
Merge branch 'develop' into feature/test-refactoring
f3c886f
@kasiakoziol
Merge branch 'feature/test-refactoring' into feature/CSPL-3775-extrac…
66abfff 
…t-common-code-in-tests
@kasiakoziol
CSPL-3775 Fix pipeline issues after the changes
1a7f67f
@kasiakoziol
CSPL-3775 Refactoring app fw tests to use before each and after each …
b7ec706 
…code
@kasiakoziol
CSPL-3775 Extracting common constants
c6161f3
@kasiakoziol
CSPL-3775 Ingest functions
27209e2
@kasiakoziol
CSPL-3775 Move verify prerequisites to setup
dd4ad6a
@kasiakoziol
CSPL-3775 Remove constants that already exist
7e4dea9
@kasiakoziol
CSPL-3775 Standardizing suite_test.go
0814b70
@kasiakoziol
CSPL-3775 Remove unused functions
4c9f8e9
@kasiakoziol
CSPL-3775 Replcaing duplicates among different tests
4d0ab80
@kasiakoziol
CSPL-3775 Eliminating duplicated v3/v4 branching logic
b55f225
@kasiakoziol
CSPL-3775 Each test case delegates to a shared Run*Test function, kee…
62a3623 
…ping the test file as a thin dispatch layer
@kasiakoziol
CSPL-3775 Standardize test code by fixing typos in log messages/comme…
4636172 
…nts, removing duplicate helpers, replacing inline logic with shared utilities
@kasiakoziol
CSPL-3775 Consistency improvements
24fb0b5
@kubabuczak
Fix Silent Failures (#1785)
5b7c1d6 
* Enhance error handling in WaitforPhaseChange and fix variable name in NewTestCaseEnv

* Updated WaitforPhaseChange to log an error if the phase transition is not observed within the timeout.
* Corrected the variable name check in NewTestCaseEnv to use the provided name instead of an uninitialized envName.
* Changed Kind from "ClusterManager" to "ClusterMaster" in ClusterMaster struct.

* Update error logging in WaitforPhaseChange to use Error level for timeout observations
@kasiakoziol
CSPL-3775 Refactoring - common naming, format and making sure functin…
5f01345 
…ality is not malformed
@kasiakoziol
CSPL-3775 Eliminate duplicated verification patterns, fix redundant c…
4bac134 
…ode, and standardize naming, godoc comments, and constants for consistency
@kasiakoziol
CSPL-3775 Reorganizing utils
34d190b
kubabuczak
kubabuczak reviewed Apr 1, 2026
View reviewed changes
Comment thread test/testenv/test_workflows.go Outdated
@kasiakoziol kasiakoziol force-pushed the feature/CSPL-3775-extract-common-code-in-tests branch from a49e621 to 2926a35 Compare April 10, 2026 08:27
kubabuczak
kubabuczak reviewed Apr 10, 2026
View reviewed changes
Comment thread test/testenv/index_ingest_separation_utils.go
kubabuczak
kubabuczak approved these changes Apr 10, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@kubabuczak kubabuczak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Let's merge it and start iterating on top of this change

One thing to double check: Verify CI pipeline label selectors still match reformatted test labels

Base automatically changed from feature/test-refactoring to develop April 14, 2026 17:57
@kasiakoziol kasiakoziol force-pushed the feature/CSPL-3775-extract-common-code-in-tests branch from 2a29a09 to a23b897 Compare April 21, 2026 11:10
@kasiakoziol kasiakoziol force-pushed the feature/CSPL-3775-extract-common-code-in-tests branch from a23b897 to 218b792 Compare April 21, 2026 12:29
@kasiakoziol kasiakoziol merged commit 47b2a05 into develop Apr 22, 2026
78 of 79 checks passed
@kasiakoziol kasiakoziol deleted the feature/CSPL-3775-extract-common-code-in-tests branch April 22, 2026 07:51
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 22, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@kubabuczak kubabuczak kubabuczak approved these changes

@vivekr-splunk vivekr-splunk vivekr-splunk approved these changes

@rlieberman-splunk rlieberman-splunk rlieberman-splunk approved these changes

@patrykw-splunk patrykw-splunk patrykw-splunk approved these changes

@Igor-splunk Igor-splunk Awaiting requested review from Igor-splunk

@gabrielm-splunk gabrielm-splunk Awaiting requested review from gabrielm-splunk

@qingw-splunk qingw-splunk Awaiting requested review from qingw-splunk

@minjieqiu minjieqiu Awaiting requested review from minjieqiu

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@kasiakoziol @kubabuczak @vivekr-splunk @rlieberman-splunk @patrykw-splunk